'abbreviate' contract violations #1490
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm unsure what's the best approach to fixing this. Should the documentation be updated to reflect the fact that for short strings, the offset marker might not be present in the result? Should the logic be changed so that the offset marker is present, and if so, what is the most efficient way? |
Member
|
The failing test: // abbreviating a shorter string allows maxWidth < 7
assertEquals("...efg", StringUtils.abbreviate("abcdefg", 5, 6));looks like a bug indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added unit tests showing incorrect behaviour of
StringUtils.abbreviateon short strings (betweenabbrevMarker.length + 1andabbrevMarker.length * 2).The documentation states that the offset character will always appear somewhere in the result, but when an offset is applied to a short string, it may not be.